Improve clean_win_ram function for better handling of non-numeric values on Windows machines#56
Open
tmossington wants to merge 1 commit intocsgillespie:mainfrom
Open
Conversation
- Updated clean_win_ram function to remove empty or non-numeric entries. - Ensured clean_win_ram function sums only valid numeric entries. Fixes csgillespie#54
Author
|
@csgillespie pinging to make sure you saw my PR, and to see if you have any comments or changes you'd like to see. |
Author
|
@csgillespie Pinging again to check if you've had a chance to review my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
These changes directly fix #49 and #54, where get_ram() fails on Windows machines because of improper handling of non-numeric values in the clean_win_ram function.
Error:
The error encountered was:
Error in inherits(ram, "try-error") || length(ram) == 0L || is.na(ram) : 'length = 9' in coercion to 'logical(1)'Changes Made:
These changes ensure that the clean_win_ram function correctly processes the RAM values on windows machines, preventing the error and allowing get_ram() to function as expected.