Fix terminal size detection when output is piped#129
Merged
rongxin-liu merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies terminal size detection so that when style50 output is piped (i.e., not connected to a TTY), diff formatting falls back to a fixed size rather than attempting to probe other streams.
Changes:
- Replace custom
ioctl-based terminal sizing withshutil.get_terminal_size(fallback=(80, 24)). - Remove low-level POSIX-specific imports used by the previous implementation.
- Bump package version to
2.11.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
style50/_api.py |
Switches terminal-size detection to shutil.get_terminal_size with a fallback for non-TTY output (e.g., piped output). |
setup.py |
Updates package version to reflect the change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
style50project by simplifying how terminal size is determined and updating the package version. The main change is the replacement of a custom function for detecting terminal size with Python's built-inshutil.get_terminal_size, which reduces code complexity and removes the need for several imports.Terminal size detection simplification:
get_terminal_sizefunction (which usedfcntl,termios, andstruct) with a direct call toshutil.get_terminal_size, simplifying the logic for determining terminal dimensions.fcntl,struct, andtermiosare no longer needed due to the simplification above.Project metadata update:
2.10.4to2.11.0insetup.pyto reflect the new changes.Closes #127