Conversation
…mentation, documentation, and dependency updates.
…ecifications and multilingual documentation.
…ion and documentation**
…e hints, and refactor Tzafon browser instance management.
…ion checks in sync and async run methods.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lib/crewai-tools/src/crewai_tools/tools/tzafon_load_tool/tzafon_load_tool.py
Show resolved
Hide resolved
lib/crewai-tools/src/crewai_tools/tools/tzafon_load_tool/tzafon_load_tool.py
Outdated
Show resolved
Hide resolved
lib/crewai-tools/src/crewai_tools/tools/tzafon_load_tool/tzafon_load_tool.py
Show resolved
Hide resolved
lib/crewai-tools/src/crewai_tools/tools/tzafon_load_tool/tzafon_load_tool.py
Show resolved
Hide resolved
lib/crewai-tools/src/crewai_tools/tools/tzafon_load_tool/tzafon_load_tool.py
Show resolved
Hide resolved
| await page.close() | ||
| await browser.close() | ||
| finally: | ||
| await computer.terminate() |
There was a problem hiding this comment.
Async method incorrectly awaits synchronous terminate call
Medium Severity
The _arun method uses await computer.terminate() but the computer object is created via a synchronous call to self.tzafon.create(kind="browser") (line 136, not awaited). Since create() is synchronous, terminate() is also likely synchronous, making the await incorrect. This will cause a TypeError at runtime when using the async execution path. The sync _run method correctly calls computer.terminate() without await on line 121.
| content = str(page_html) | ||
|
|
||
| page.close() | ||
| browser.close() |
There was a problem hiding this comment.
Redundant explicit page and browser cleanup calls
Low Severity
The explicit page.close() and browser.close() calls are redundant. Playwright's context manager (with sync_playwright() / async with async_playwright()) automatically handles cleanup on exit. Additionally, computer.terminate() in the finally block destroys the entire remote environment, making browser resource cleanup unnecessary. No other tool in the codebase includes these explicit cleanup calls. This was noted in the PR discussion as well.
Additional Locations (1)
Add native Tzafon provider with OpenAI-compatible chat completions, streaming, tool calling, and token usage tracking. Includes docs (EN, KO, PT-BR), provider constants, and unit tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "completion_tokens": getattr(usage, "completion_tokens", 0), | ||
| "total_tokens": getattr(usage, "total_tokens", 0), | ||
| } | ||
| return {"total_tokens": 0} |
There was a problem hiding this comment.
TzafonCompletion is large near-copy of OpenAI provider
Medium Severity
TzafonCompletion is a ~730-line class that duplicates nearly all logic from the existing OpenAICompletion provider (completion handling, streaming, tool calling, token tracking, error handling) with only the API key env var name and base URL differing. Since Tzafon's API is explicitly OpenAI-compatible, this could be achieved by configuring the existing OpenAICompletion with a different base_url and api_key source, avoiding a large maintenance burden and risk of the copy diverging over time.
- Add Arabic (ar) documentation translations - Add skills system with loader, parser, and validation - Add agent planning configuration and step executor - Add flow serializer and observation events - Update MCP tools, memory storage, and LLM providers - Add OpenAI-compatible provider support - Update crewai-tools and crewai-files libraries - Add comprehensive test coverage for new features Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0181542292
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lib/crewai/src/crewai/llm.py
Outdated
| "hosted_vllm", | ||
| "cerebras", | ||
| "dashscope", | ||
| "tzafon", |
There was a problem hiding this comment.
Adding tzafon to openai_compatible_providers makes _get_native_provider return OpenAICompatibleCompletion for this provider, but that class has no tzafon entry in OPENAI_COMPATIBLE_PROVIDERS, so LLM("tzafon/tzafon.sm-1") (or provider="tzafon") fails with an unknown-provider error instead of using the new TzafonCompletion. This leaves the advertised Tzafon integration unreachable at runtime.
Useful? React with 👍 / 👎.
| await page.close() | ||
| await browser.close() | ||
| finally: | ||
| await computer.terminate() |
There was a problem hiding this comment.
The async implementation calls await computer.terminate(), but the same SDK object is terminated synchronously in _run and the Tzafon Computer API uses a non-async terminate() method. Awaiting it will raise a TypeError during cleanup, causing _arun calls to fail even after successful navigation/extraction.
Useful? React with 👍 / 👎.
…te tzafon load tool termination logic
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2e54d6abb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def supports_stop_words(self) -> bool: | ||
| """Check if the model supports stop words.""" | ||
| return self._supports_stop_words_implementation() |
There was a problem hiding this comment.
TzafonCompletion implements native tool-call handling but never defines supports_function_calling(), unlike the other native providers. Multiple core paths call this method directly (for example Converter.to_pydantic and task evaluation flows), so using a Tzafon LLM there will raise AttributeError before any model request is made. Adding this capability method is necessary to keep the provider compatible with the expected native LLM interface.
Useful? React with 👍 / 👎.
| response: ChatCompletion = await self.async_client.chat.completions.create( | ||
| **params | ||
| ) |
There was a problem hiding this comment.
When self.stream is enabled, _prepare_params() adds stream=True, but acall() still always routes into _ahandle_completion(), which expects a non-streaming ChatCompletion. In async mode this call returns a stream object, so the later response.choices[0] access fails and breaks acall() for streaming configurations. This path needs a dedicated async streaming handler (as done in other native providers).
Useful? React with 👍 / 👎.
… calling for Tzafon provider
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a52be34f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if tool_calls and available_functions: | ||
| for call_data in tool_calls.values(): |
There was a problem hiding this comment.
This streaming path only handles tool calls under if tool_calls and available_functions, so when tools are enabled but available_functions is intentionally omitted, the method falls through and returns full_response (often empty) instead of the tool-call payload. That breaks the same workflow supported by non-streaming calls (return raw tool calls for external execution) and causes streamed tool invocations to be silently dropped; the async streaming method has the same omission.
Useful? React with 👍 / 👎.
| content = message.content or "" | ||
| content = self._apply_stop_words(content) | ||
|
|
There was a problem hiding this comment.
In _ahandle_completion, the async non-streaming flow goes straight from message.content to stop-word truncation and return, but it never runs the structured-output validation that the sync _handle_completion path applies for self.response_format model types. This makes acall() return raw text for typed response_format configurations, causing type mismatches and skipped schema enforcement for async users.
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…red output in Tzafon provider
1 participant
Affiliation: Tzafon
This pull request introduces the new
TzafonLoadTool, a tool for programmatic web scraping and browser automation using the Tzafon platform. It adds support for Tzafon in the codebase, updates documentation in English, Korean, and Portuguese, and ensures the tool and its dependencies are properly integrated and documented for end users.Key changes include:
Tool Implementation and Integration
TzafonLoadToolimplementation to provide programmatic control and data extraction from web pages via the Tzafon browser API, supporting both synchronous and asynchronous usage.TzafonLoadToolin thecrewai_toolspackage for import and use, and included it in the__all__exports. [1] [2]pyproject.tomlunder the[project.optional-dependencies]section..env.test.Documentation Updates
TzafonLoadTool, including installation, usage, arguments, and example code. [1] [2]TzafonLoadTool, with translated descriptions, installation instructions, and usage examples. [1] [2]TzafonLoadTooland its description. [1] [2] [3] [4] [5] [6] [7]These changes collectively enable users to leverage Tzafon for advanced web scraping and browser automation tasks, with comprehensive multilingual documentation and seamless integration into the existing tool suite.
Note
Medium Risk
Adds a new native LLM provider and a Playwright-based web loading tool that invoke external services, which can affect runtime behavior, dependency resolution, and error handling paths. Risk is mitigated by added model constants and a fairly comprehensive mocked test suite for routing, streaming, and tool-calling.
Overview
Adds native Tzafon LLM support by introducing
TzafonCompletion, registeringtzafonas a supported native provider inLLMrouting, and addingTZAFON_MODELSplus context-window entries fortzafon.sm-1andtzafon.northstar-cua-fast.Introduces a new web scraping/automation tool
TzafonLoadTool(sync + async) that uses Tzafon’sComputer+ Playwright CDP connection to load a URL and return either text or full HTML; it’s exported viacrewai_tools, added totool.specs.json, and wired with aTZAFON_API_KEYenv var.Updates packaging and docs: adds
tzafonoptional dependency group (anduv.lockentries), addsTZAFON_API_KEYto.env.test, and documents the provider/tool in EN/KO/pt-BR (including newtzafonloadtool.mdxpages and navigation/listing updates).Written by Cursor Bugbot for commit cca0861. This will update automatically on new commits. Configure here.