Skip to content

Sidebar close on body click#58

Open
abhinand-c wants to merge 2 commits into
creativetimofficial:masterfrom
abhinand-c:patch-2
Open

Sidebar close on body click#58
abhinand-c wants to merge 2 commits into
creativetimofficial:masterfrom
abhinand-c:patch-2

Conversation

@abhinand-c
Copy link
Copy Markdown

Fix for issue of sidebar not collapsing upon body click.
Fix Issue #55

Fix for issue of sidebar not collapsing upon body click.
update fix sidenavbar
Issue creativetimofficial#55
@jhonnattan123
Copy link
Copy Markdown

please include this

#38

and add defualt in click event

This is because when the screen is resized, the option to hide the menu is broken
image

@jhonnattan123
Copy link
Copy Markdown

and modify
image
to
image

@dragosct dragosct requested a review from rarestoma October 12, 2020 07:35
@DaWe35
Copy link
Copy Markdown

DaWe35 commented Oct 29, 2020

Ohh no I spend hours doing the same @timcreative please merge!

@DaWe35
Copy link
Copy Markdown

DaWe35 commented Nov 29, 2020

thank you dear big bro ,
It's Work 101% ...
I but in mobile when we click sidnav not close still
can you please help me ....

thank you once agin

I think we already fixed in https://github.com/DaWe35/SkyID/blob/main/dist/assets/js/argon.js
Issue, commits: DaWe35/SkyID#20

@daniel-farina
Copy link
Copy Markdown

This should be merged, it's a big issue. The sidebar is completely stuck on body click. It's def a bug.

Thanks for the fix guys.

@iyobo
Copy link
Copy Markdown

iyobo commented May 17, 2021

@timcreative please merge

@rarestoma
Copy link
Copy Markdown
Contributor

Hi guys,

Thank you for working with our products and for fixing this issue.

I just added it in the 'to do' list for the next update.

Best regards,
Rares

@jovialcore
Copy link
Copy Markdown

Hi...what is the update ? I highly recommended this pull request be merge. Nice work @abhinand-c abhinand-c @rarestoma what is the update please. Nice work @timcreative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants