Python/SQLAlchemy: Stop testing experimental features

[amotl]

About

To increase the stability of integration tests touched hereby, leave testing against the stale amo/postgresql-async development branch behind.

Details

amo/postgresql-async is a development branch, and it can no longer easily be refreshed. It is better to demonstrate only GA features anyway, and flag the experimental ones appropriately.

Reason

All those CI jobs are failing otherwise.

• Build(deps): Update sqlalchemy requirement from <2.1,>=2.0.49 to >=2.0.51,<2.1 in /by-language/python-sqlalchemy #1799
• Build(deps): Update crate requirement from >=2.1.2 to >=2.2.1 in /by-language/python-sqlalchemy #1808
• Build(deps): Update crate requirement from >=2.1.2 to >=2.2.1 in /by-dataframe/pandas #1816

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 962fd6d3-4edb-45f6-b773-e197d8781abe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[amotl]

We will limit versions here for now, so that subsequent Dependabot submissions will show us when things might go south.

[amotl]

See also my other comment.

• Switch sqlalchemy-cratedb from dev branch to released 0.43.1 #1867 (review)

[amotl]

@florinutz or @kneth: Can I humbly ask you to acknowledge and merge this, so that touched integration tests include less obstacles? It will help to sort out other details coming from recent package updates:

• Python/SQLAlchemy: Statement exceeds statement_max_length sqlalchemy-cratedb#284

[kneth]

Could we enable the test when we wish to? For example, something like

@pytest.mark.skipif(
    os.getenv("ENABLE_EXPERIMENTAL") == None,
    "Experiemental feature")

[amotl]

Keep it but gate it?

Could we enable the test when we wish to?

The patch was meant to remove that reference to the development branch at git+https://github.com/crate-workbench/sqlalchemy-cratedb@amo/postgresql-async from the central requirements.txt file of this exercise, so Dependabot or Renovate can better drive its dependencies. Otherwise, the exercise is locked to a development branch, which is unfortunate for future maintainers, because it is adding additional complexity to decipher what's going on. Also, Dependabot or Renovate can't do anything about it, which slows down evolution and complicates quality assurance.

This patch is intended to clean and clear things up for the better.

pytest to the rescue?

For example, something like

@pytest.mark.skipif(
    os.getenv("ENABLE_EXPERIMENTAL") == None,
    "Experiemental feature")

cratedb-examples is not a traditional Python project. Each folder includes arbitrary projects of arbitrary kinds. In this spirit, traditional ways to cover experimental tests are mostly not much applicable.

In this case, because removing the smell is in the dependency definition file zone, such a way to wrap experimental features is also not feasible. Apologies!

[bgunebakan]

Hi,
I saw your PR late. Yes it's a duplication, but We don't wanna downgrade sqlalchemy-cratedb versions because raised issues already fixed in repos. Examples are ready for new version change.
Thank you,

Bilal