Network settings UX review: fix defects, surface addresses and status - #2164
Closed
cpvalente wants to merge 3 commits into
Closed
Network settings UX review: fix defects, surface addresses and status#2164cpvalente wants to merge 3 commits into
cpvalente wants to merge 3 commits into
Conversation
Fixes a set of verified defects in the network settings surfaces: - self-row highlight was invisible on even rows, as the shared table's `tr:nth-child(even)` stripe outranks a plain class selector - client table used `<td>` for header cells, so it received none of the `th` styling applied across the other settings tables, and offered no header association for assistive technology - the redirect modal disabled its view Select whenever no URL presets existed, even though that Select also holds every built-in view, so the control was dead on a fresh project - the log store grew without bound; capped to a rolling window - network interfaces displayed a bare IP while copying a full URL with the port, sending users to an address that cannot connect - client rows followed broadcast insertion order and shuffled on reconnect, making it easy to action the wrong row - the rename modal had no autofocus and no submit on Enter Also restores the identify blink, which referenced a class that was never defined. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FdRte3v1Swc2MRt9fKJTXk
The network panel showed events and clients but never answered the two questions users arrive with: which address to hand out, and whether the setup is healthy. Addresses lived in the sharing panel, and the session stats endpoint the server already serves had no client consumer. - add a server address card composing the existing interface list with the port, linking to the port form rather than duplicating it - add a server status card reading the existing session endpoint for uptime, connected clients, last connection and last integration request - give the log a text search, an issues-only filter and a visible count of filtered versus total entries - relabel the log's Extract action, which opens a window rather than exporting - normalise the panel to the card rhythm used elsewhere in settings, and add the new sections to the settings sidebar - describe what each section is for, and give the client tables empty states that explain rather than sit blank Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FdRte3v1Swc2MRt9fKJTXk
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- restore text selection on the client path cell; the global `user-select: none` means the cell needs `.copiable` explicitly, which was lost when the path moved into a button - drop the click-to-open action from the path cell, which followed from making it read-first; copy still yields the full client URL - stop passing the current client id when sorting other clients, which can never contain it - remove two width rules that no styles reference - cover the redirect view select with no url presets, a case the suite did not exercise and which the other three cases pass without Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FdRte3v1Swc2MRt9fKJTXk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A UX/UI review of the Network settings panel, focused on low-risk, low-complexity changes: fix real defects first, then close the two gaps operators actually hit (which address to hand out, whether the setup is healthy).
Verified defects fixed:
<td>instead of<th>, so they got none of the shared header styling and no screen-reader associationblinkclass that was never defined, so the flash feedback never renderedNew in the panel:
GET /api/session/endpoint for uptime, connected clients, last connection/request, timezone, versionDeliberately out of scope: the share-link builder/QR form, any server or
packages/typeschanges, ping behavior, and bulk client actions.Test plan
pnpm typecheckcleanpnpm lint— unchanged at the pre-existing 120-warning baselinepnpm --filter ontime-ui buildsucceeds (confirms SCSS compiles)GET /data/session/against a running server and confirmed the response matches what the new status card expectse2e/tests/features/210-client-remote.spec.ts(redirect / identify / rename) passes unchanged — testids preserved212-time-until › time until absolutefails pre-existing, verified via a clean worktree)Generated by Claude Code