gtk.cfg: Remove transfer none function g_application_get_default#8545
Open
Tamaranch wants to merge 1 commit into
Open
gtk.cfg: Remove transfer none function g_application_get_default#8545Tamaranch wants to merge 1 commit into
Tamaranch wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for your contribution, please add a test to test/cfg/gtk.c. |
a827403 to
fd1c867
Compare
Author
Done. Note that I need to add |
| <use>g_file_attribute_matcher_ref</use> | ||
| <dealloc>g_file_attribute_matcher_unref</dealloc> | ||
| </memory> | ||
| <function name="g_application_get_default"> |
Collaborator
There was a problem hiding this comment.
Should this have use-retval?
Author
There was a problem hiding this comment.
Yes, I think so, in the sense that it's pointless to call this function and ignore the return value (so it's not as serious as ignoring the return value of g_list_prepend, for example). I’ve added it, along with the return type.
fd1c867 to
6e337ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://docs.gtk.org/gio/type_func.Application.get_default.html