feat: Check antivirus status in HTTP handlers #4631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
requested changes
Dec 18, 2025
Comment on lines
+1456
to
+1462
| // Check antivirus status for files | ||
| if file != nil { | ||
| if err = CheckAntivirusAction(instance, file, ActionDelete); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This will prevent trashing files with viruses. I don't think we want that.
Contributor
Author
There was a problem hiding this comment.
it depends on the configuration. If we configure the stack to prevent it, we should do it
Comment on lines
+1612
to
+1618
| // Check antivirus status for files | ||
| if file != nil { | ||
| if err = CheckAntivirusAction(inst, file, ActionDelete); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This will prevent permanently deleting files with viruses. This is the opposite of what we want I believe :).
Contributor
Author
There was a problem hiding this comment.
We can delete them with vfs API, we just forbid actions to users/konnectors that are configured as forbidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files are now checked against their antivirus scan status before download, preview, share, and delete operations. When an action is blocked based on configuration, the API returns HTTP 451 (Unavailable For Legal Reasons) with details about the blocked action and detected threat.