Fix FA21RF smoke detector detection#73
Open
andyboeh wants to merge 1 commit into
Open
Conversation
cpainchaud
added a commit
to cpainchaud/RFLink32
that referenced
this pull request
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got a FA21RF smoke detector that was not properly detected by my ESP but works with the original RFLink. When comparing the raw signals, the original RFLink receives two more bytes at the beginning, but throws them away. The ESP RFLink does not receive these two bytes, unless
SIGNAL_END_TIMEOUT_USis increased to about 10000. Since I expect side effects from that, I changed the FA21RF signal detection.Transmission is untested as the transmitter behaves a bit weird on my Wemos D1 Mini. I'll investigate this later.