[BROKEN] make SoundContainer use shared_ptr everywhere#265
Draft
Architector4 wants to merge 1 commit intocortex-command-community:developmentfrom
Draft
[BROKEN] make SoundContainer use shared_ptr everywhere#265Architector4 wants to merge 1 commit intocortex-command-community:developmentfrom
Architector4 wants to merge 1 commit intocortex-command-community:developmentfrom
Conversation
i tried but luabind 0.7.1 will not eat `std::shared_ptr` and i can't use `boost::shared_ptr` because the included boost headers literally do not have it for some reason so i'm just leaving this here as an archive of my work that might one day become workable if luabind is ever updated in this project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i tried but luabind 0.7.1 will not eat
std::shared_ptrand i can't useboost::shared_ptrbecause the included boost headers literally do not have it for some reasonso i'm just leaving this here as an archive of my work that might one day become workable if luabind is ever updated in this project