gitignore - also ignore *.sh#235
Draft
Architector4 wants to merge 1 commit intocortex-command-community:developmentfrom
Draft
gitignore - also ignore *.sh#235Architector4 wants to merge 1 commit intocortex-command-community:developmentfrom
Architector4 wants to merge 1 commit intocortex-command-community:developmentfrom
Conversation
Shell files are basically the Linux equivalent of WIndows's *.bat files, which are already excluded. This is handy for me because I like using scripts for things lol
HeliumAnt
requested changes
Nov 21, 2025
Contributor
HeliumAnt
left a comment
HeliumAnt
left a comment
There was a problem hiding this comment.
Not sure about this. We have a few scripts that occasionally need updating, especially for CI and releases (i know it's not that big a deal to force update but it's easily missed). Explicitly should be disabled in external/ mainly for sdl, which uses a bunch of scripts in its build process (updating sdl is already enough work as is, having unexpected ci errors from suddenly missing files doesn't help).
Contributor
Author
|
...Huh, did not expect there to be critical .sh files but not .bat files. My bad. How about excluding just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell files are basically the Linux equivalent of WIndows's *.bat files, which are already ignored. This is handy for me because I like using scripts for things lol