Draft
Conversation
Contributor
HeliumAnt
commented
Dec 20, 2024
HeliumAnt
commented
- fix macos build
- add macos ARM CI
Contributor
|
What extra work needs to be done here? Just testing etc? Also- can we distribute for ARM Linux too? FWIW I was running native ARM when I was developing on Mac M1 and it worked perfectly, so I don't imagine we should see any issues here. |
Contributor
Author
|
yes just testing. The linux flatpak release already includes ARM builds, all that needs to be done there is add CI builds. I'll probably want to move the linux CI to target the Freedesktop SDK as well. |
Causeless
reviewed
Jul 13, 2025
| SDL_GL_SetAttribute(SDL_GL_CONTEXT_MAJOR_VERSION, 3); | ||
| SDL_GL_SetAttribute(SDL_GL_CONTEXT_MINOR_VERSION, 3); | ||
| SDL_GL_SetAttribute(SDL_GL_CONTEXT_PROFILE_MASK, SDL_GL_CONTEXT_PROFILE_CORE); | ||
| SDL_GL_SetAttribute(SDL_GL_CONTEXT_MINOR_VERSION, 1); |
Contributor
There was a problem hiding this comment.
Are these changes still necessary/valid with the changes in b5b183e?
Contributor
There was a problem hiding this comment.
Oh, that CL is older. No idea why it's merge conflicting, but eh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.