Added scenario validation#45
Open
ningning621 wants to merge 2 commits into
Open
Conversation
leotrj
requested changes
Sep 23, 2017
| import java.util.Collection; | ||
| import java.util.List; | ||
| import java.util.NoSuchElementException; | ||
| import java.util.*; |
Contributor
There was a problem hiding this comment.
Is downloading all of the packages necessary? It might be better to just download the ones we are using for now.
| return false; | ||
| } | ||
|
|
||
| if (!object.get("position").getAsString().matches("\\[\\d,\\d]")) { |
Contributor
There was a problem hiding this comment.
Just curious, whats the purpose of this?
| return false; | ||
| } | ||
| } | ||
| if (numBot != 1) { |
Contributor
There was a problem hiding this comment.
is this to make sure that we only have one bot at a time?
| // xboxControllerDriver == null | ||
| // might get this request from stopXbox HTTP post | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Documentation pls!
/**
* [Description of the function]
* Input:
* [variable name] - [what it is]
* Output:
* [what does it return? ]
*/
^^ follow a format similar to this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.