This repository was archived by the owner on Mar 28, 2020. It is now read-only.
fix sort, with a helper so the sort is done 'naturally'#2099
Open
jurgenweber wants to merge 4 commits intocoreos:masterfrom
Open
fix sort, with a helper so the sort is done 'naturally'#2099jurgenweber wants to merge 4 commits intocoreos:masterfrom
jurgenweber wants to merge 4 commits intocoreos:masterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
2 similar comments
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
Can one of the admins verify this patch? |
Author
|
so I built the image and used it overnight, it works as expected now. Thanks |
daxmc99
reviewed
Jul 3, 2019
daxmc99
approved these changes
Jul 3, 2019
daxmc99
left a comment
daxmc99
left a comment
There was a problem hiding this comment.
Looks good to me but I'm not associated with coreos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/coreos/etcd-operator/blob/master/CONTRIBUTING.md#contribution-flow
I hit the edge case that when it sorts, it thinks
etcd_v1066060_2019-07-02-02:51:51
is smaller/older than
etcd_v999523_2019-06-30-14:56:49
because it is sorting on the first digit only.
Added all the stuff needed to sort this properly.
right now the periodic backup is continually deleting the same file.