This repository was archived by the owner on Mar 28, 2020. It is now read-only.
ADDED: prometheus exporter for backup-operator#2096
Open
jescarri wants to merge 1 commit intocoreos:masterfrom
Open
ADDED: prometheus exporter for backup-operator#2096jescarri wants to merge 1 commit intocoreos:masterfrom
jescarri wants to merge 1 commit intocoreos:masterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
2 similar comments
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
Can one of the admins verify this patch? |
jescarri
force-pushed
the
add_prometheus_metrics_backup
branch
from
89274f4 to
c508235
Compare
Author
|
Hi @hexfusion any feedback on this PR? Thanks! |
Author
|
@hasbro17 @hongchaodeng @xiang90 @fanminshi @rjtsdl Hey guys sorry for the direct reach, can I get some help on this PR?. Thanks! |
Contributor
|
LGTM overall, can we use basic http rather than introduce garrilia router? My point is, it is not exporting other path except /metrics. A simple http.Handle should be enough. |
jescarri
force-pushed
the
add_prometheus_metrics_backup
branch
from
c508235 to
e4e63ab
Compare
Added a few metricts and an exporter to the backup operator. Related to: coreos#2095 Removed gorilla mux
jescarri
force-pushed
the
add_prometheus_metrics_backup
branch
from
e4e63ab to
6309d49
Compare
Author
|
@rjtsdl done, removed the gorilla mux dependency. |
rjtsdl
suggested changes
Jul 13, 2019
Contributor
rjtsdl
left a comment
rjtsdl
left a comment
There was a problem hiding this comment.
Can you introduce a metrics port flag instead of hard code it? You can check how etcd-operator does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added prometheus exporter for the etcd-backup-operator.