Add curl image parameter

[atiannicelli]

cluster: add option to specify curl image

add an option in EtcdCluster.spec:
CurlImage. Defaults to "tutum/curl:latest"

see #1933

[etcd-bot]

Can one of the admins verify this patch?

[etcd-bot]

Can one of the admins verify this patch?

[etcd-bot]

Can one of the admins verify this patch?

[marcostvz]

hi @hasbro17, I need this feature too, could you or any other maintainer take a look? Thanks! :)

[alaypatel07]

Thanks for the PR. The CurlImage parameter is only consumed by the EtcdRestore cr and the PodPolicy is consumed by EtcdCluster.

IMO it is better to add it to the restore spec here

[alaypatel07]

Should be added to EtcdRestore struct

[atiannicelli]

I am following the example of the "busyboxImage" parameter which specific to etcRestore as well. I see how you could say that it belongs there, but I feel these should stay together. THIS fix is to add the curlImage. If we want another fix to move them both to EtcdRestore I can see that working, but I would rather keep this as is.

[alaypatel07]

I thought the busyboxImage parameter is used for all etcd cluster pods and not just etcd restore

etcd-operator/pkg/util/k8sutil/k8sutil.go

Line 374 in b2a63ce

Image: imageNameBusybox(cs.Pod),

[vaneyckt]

hi @hasbro17, I just ran into this today as well. @atiannicelli do you need someone to take over from you on this?

[atiannicelli]

We have been using this change for a few months and it works fine. I don't know how to "take it from here" as I don't have merge ability and it seems that the tests are not being run above. I don't know who to contact to get an approving review from someone with write access.