feat: add ExtractTextElements and OpenFromBytes APIs#70
Merged
Conversation
- Add public TextElement struct with Text, X, Y, Width, Height, FontName, FontSize fields - Add Page.ExtractTextElements() returning positioned text runs with error propagation - Add Document.ExtractTextElementsFromPage(pageNum int) convenience method (1-based) - Refactor internal/parser/Reader to use io.ReadSeeker + io.Closer instead of *os.File - Cache fileSize at open time to avoid repeated Stat() calls - Add nil guard in parseObjectAtOffset so closed readers return an error, not a panic - Add parser.NewReaderFromBytes, OpenPDFFromBytes, OpenPDFFromBytesWithPassword - Add public gxpdf.OpenFromBytes, OpenFromBytesWithContext, OpenFromBytesWithPassword, OpenFromBytesWithPasswordAndContext - Add 30 tests covering ExtractTextElements, OpenFromBytes, and error paths
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page.ExtractTextElements()andDocument.ExtractTextElementsFromPage()— expose positioned text runs with X, Y, Width, Height, FontName, FontSize through the public APIOpenFromBytes(),OpenFromBytesWithPassword(), and context-aware variants for in-memory PDF opening without filesystem I/OReaderfrom*os.Filetoio.ReadSeekerinterface with cachedfileSize, enablingbytes.NewReaderas backendCloses #68
Test plan
go fmt ./...cleango vet ./...cleango test ./...— 23 packages, all passinggolangci-lint run— no new issues