fix(passkeys_darwin): place Package.swift at Flutter-conventional path#239
Merged
Conversation
31d7ca5 to
c0096c1
Compare
Adds Package.swift at the Flutter-conventional path so Flutter's plugin tooling discovers it (FlutterGeneratedPluginSwiftPackage now includes passkeys_darwin and the plugin is consumed via SwiftPM rather than falling back to CocoaPods). - Package.swift at darwin/passkeys_darwin/ (matches shared_preferences_foundation) - Swift sources moved to darwin/passkeys_darwin/Sources/passkeys_darwin/ - Podspec source_files path and deployment targets aligned with Package.swift (iOS 13.0, macOS 10.15); @available runtime gating unchanged - .gitignore for SwiftPM build artifacts - CLAUDE.md note documenting dual-build (SwiftPM + CocoaPods) convention Verified on iOS and macOS in both modes: with SwiftPM enabled, passkeys_darwin appears in the generated SwiftPM graph and drops out of Podfile.lock; with SwiftPM disabled, the updated podspec source_files path resolves and pod install pulls the plugin as before. Closes #234. Closes #235.
c0096c1 to
23fd8ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SwiftPM support to
passkeys_darwinusing the Flutter plugin layout convention. Closes #234. Closes #235.Package.swiftatdarwin/passkeys_darwin/darwin/passkeys_darwin/Sources/passkeys_darwin/source_filesand deployment targets aligned (iOS 13.0, macOS 10.15).gitignorefor SwiftPM artifactsVerified on iOS and macOS:
passkeys_darwinresolves via SwiftPM and drops out ofPodfile.lock. No version bump — to be done as a separate post-merge commit per the usual release flow.Credit @Dopeamin for opening #235 and surfacing this.