fix: improve cooking mode responsiveness on smartphones#306
Conversation
Fixes #305. The cooking mode overlay was not properly responsive on small screens, with badges overflowing, oversized text, and header elements not fitting. - Add overflow-x: hidden to cards to prevent horizontal scrollbar - Reduce card margins and padding on mobile for more content space - Scale down badge font sizes and allow text wrapping on mobile - Shrink header elements (title, section pills, close button) - Reduce font sizes for step text, mise-en-place items, and done card
Code ReviewGood targeted fix for the mobile cooking mode overflow issues. The changes are clean, well-scoped, and address a real usability problem. Here is my feedback: What is working well
Issues and suggestions1. Long ingredient names can still overflow at the character level
.cooking-step-text .ingredient-badge,
.cooking-step-text .cookware-badge,
.cooking-step-text .timer-badge {
font-size: 16px;
padding: 1px 8px;
white-space: normal;
overflow-wrap: break-word;
word-break: break-word;
}2. The fix is in the base style block, not inside the 3. No intermediate breakpoint coverage The gap between 640px and 1024px (tablet range / landscape phones) may still have some awkward sizing. Out of scope for this fix but worth a follow-up issue. 4. Missing regression test The project has Playwright test infrastructure including mobile viewport tests ( VerdictThe fix is solid and the approach is correct. The main actionable item before merging is adding |
Code ReviewPR: fix: improve cooking mode responsiveness on smartphones This is a solid set of responsive fixes. The changes are well-scoped to What's good
Concerns
13px is below the generally recommended minimum legible size (16px body, 14px secondary). On a real device this may be hard to read during active cooking. Consider 14px as a floor. No landscape orientation handling
@media (max-width: 640px) and (orientation: landscape) {
.cooking-card {
max-height: 85vh;
}
}would help, though this could be a follow-up issue rather than blocking this PR.
Adding Test coverageThe test plan in the PR description is manual (Chrome DevTools emulation + real device). Given the project has no automated E2E tests for this flow, that's appropriate. The plan covers both viewport widths mentioned (375px and 428px). Overall: Approve. The |
Fixes #305
Summary
overflow-x: hiddento cooking mode cards to prevent horizontal scrollbar from badge overflowcalc(100% - 24px)vs40px) and padding on mobile for more content spacewhite-space: normal) on mobileTest plan