Implement error presenter routing module #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements ErrorPresenterLocator interface and ModuleErrorPresenterLocator class that routes error presenter requests to module-specific error presenters based on configurable patterns. Configuration example: 'Front:*' => 'Front:Error' 'Admin:*' => 'Admin:Error' This allows different modules to have their own error presenters, enabling customized error handling per module (e.g., different error pages for frontend vs admin sections). Closes #4
- Add Admin/ErrorPresenter fixture for admin module errors - Add Front/ErrorPresenter fixture for frontend module errors - Add DefaultErrorPresenter fixture as fallback - Add ModuleErrorPresenterRoutingTest with comprehensive test cases demonstrating real-world usage scenarios
- Add Front:Homepage and Front:Article presenters that throw errors - Add Admin:Dashboard and Admin:User presenters that throw errors - Add ApplicationErrorHandlingTest that simulates real application run: - Presenters throw RuntimeException/BadRequestException - ModuleErrorPresenterLocator routes to correct error presenter - Validates error presenter response contains expected error message - Tests full error handling flow with request parameters preserved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.