Conversation
jmairboeck
force-pushed
the
cmake-fixes
branch
from
cf9e0ab to
c842f54
Compare
This uses `find_package(ZLIB)` when building from source to optionally avoid the submodule and use an installed zlib instead.
When specifying `DESTINATION lib`, all files get installed there, also the headers, therefore don't specify it so that files get installed in their default location instead. Also include GNUInstallDirs to make the installation paths configurable using standard CMake variables CMAKE_INSTALL_INCLUDEDIR and CMAKE_INSTALL_LIBDIR.
jmairboeck
force-pushed
the
cmake-fixes
branch
from
c842f54 to
a3932ea
Compare
|
I also added a 3rd commit to install the missing headers also. pplib.h includes the other headers, so it needs them. I'm not sure if this is a good solution though. |
|
Thanks a lot. The changes are "not so elegant", but at least they don't affect builds on old systems. I did not test anything yet, but I believe that this could be merged once it gets tested. Personally I would suggest to put the list of headers into a separate PR, so that these can be merged independent from each other. @paweljackowski, can you please take a look at this MR? |
jmairboeck
force-pushed
the
cmake-fixes
branch
from
a3932ea to
d06b165
Compare
|
I separated the third commit into its own PR: #6 |
paweljackowski
left a comment
paweljackowski
left a comment
There was a problem hiding this comment.
I neither use nor can verify changes in cmakefiles. If the change works for you, perfectly ok for me.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
3 participants
These changes allow to easier build this standalone.