Reset create_pid after waitpid to prevent signaling unrelated processes#659
Merged
Conversation
After the synchronous waitpid(create_pid) succeeds, create_pid was never reset to -1. If the PID was later reused by another process, on_sig_exit() would send SIGTERM to that unrelated process. Resolves: RHEL-178025 Signed-off-by: Jindrich Novy <jnovy@redhat.com>
|
Ephemeral COPR build failed. @containers/packit-build please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the synchronous waitpid(create_pid) succeeds in the non-terminal
code path, create_pid was never reset to -1. If the PID was later reused
by another process, on_sig_exit() would send SIGTERM to that unrelated
process.
This was observed in OpenStack environments where restarting container
services would occasionally kill qemu-kvm instances whose PIDs happened
to match a previously reaped create_pid.
Fix: set create_pid = -1 after successful waitpid(), matching the
behavior already present in the terminal path via runtime_exit_cb().
Resolves: RHEL-178025