feat(cli): separate cnc and pgpm CLIs - hard separation #500
+3,057
−7,736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove all pgpm commands from cnc CLI, keeping only GraphQL commands: - server, explorer, codegen, get-graphql-schema - Create local utility files to replace pgpm dependencies: - argv.ts, cli-error.ts, update-check.ts - Update usage text to only show GraphQL commands - Update README.md to focus on GraphQL commands and reference pgpm - Update QUICKSTART.md to use pgpm for database operations - Update AGENTS.md to clarify the separation - Update tests to use pgpm instead of cnc for database commands This eliminates branding confusion between cnc (GraphQL server/tools) and pgpm (PostgreSQL package manager/migrations).
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The test fixture now routes pgpm commands to the pgpm CLI, allowing tests to use pgpm for database operations while cnc is used only for GraphQL commands.
Use relative import path to pgpm/cli/src/commands instead of the pgpm package which doesn't export the commands function.
Tests for pgpm functionality (init, add, extension, package) now import commands from pgpm/cli/src/commands instead of cnc's commands since these operations are no longer available in cnc.
Complete separation of test infrastructure: - Move all pgpm-related tests from packages/cli to pgpm/cli - Create pgpm/cli/test-utils with fixtures, CLI helpers, and TestDatabase - Clean up packages/cli test-utils to only support cnc GraphQL commands - Remove unused test utilities from packages/cli (CLIDeployTestFixture, init-argv) - Keep only GraphQL tests in packages/cli (codegen, get-graphql-schema, cli) This ensures no cross-package imports between cnc and pgpm test code.
Remove snapshot files that belonged to tests that were moved: - packages/cli: remove pgpm test snapshots (add, extensions, init.install, init, package) - pgpm/cli: remove cli.test.ts.snap (was copied but not needed)
Remove outdated references to createPgpmCommandMap() and PGPM command delegation. Update documentation to reflect that cnc now only has 4 GraphQL commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(cli): separate cnc and pgpm CLIs - hard separation
Summary
This PR implements a hard separation between
cnc(Constructive CLI) andpgpm(PostgreSQL Package Manager) to eliminate branding confusion.Before:
cncincluded all 22+ pgpm commands plus GraphQL commandsAfter:
cnconly has 4 GraphQL-focused commands:server,explorer,codegen,get-graphql-schemaKey changes:
pgpmfor database operationspackages/clitopgpm/cli- complete test infrastructure separationpgpm/cli/test-utilswith fixtures, CLI helpers, and TestDatabasepackages/cli/test-utilsto only support cnc GraphQL commandsUpdates since last revision
packages/cli/__tests__topgpm/cli/__tests__pgpm/cli/test-utils/with CLIDeployTestFixture, fixtures, cli helpers, and init-argv utilitiespackages/cli(CLIDeployTestFixture, TestDatabase, init-argv)packages/cli/__tests__now only contains GraphQL tests:codegen.test.ts,get-graphql-schema.test.ts,cli.test.ts../../../pgpm/cli/src/commands) in test codecreatePgpmCommandMap()and PGPM command delegationReview & Testing Checklist for Human
This is a breaking change that affects all users who were using
cncfor database operations.cnc server,cnc explorer,cnc codegen, andcnc get-graphql-schemato confirm they still functioncnc deploy,cnc init, etc. now shows "Unknown command" errorpnpm testin bothpackages/cliandpgpm/clito ensure test separation is correct~/.constructive/. Verify the version comparison logic and file-based caching work correctlyRecommended test plan:
cd packages/cli && pnpm link --globalcnc --helpand verify only 4 commands are showncnc serverin a workspace with a database to verify GraphQL server workscnc deployand verify it fails with "Unknown command: deploy"cd pgpm/cli && pnpm testto verify pgpm tests passcd packages/cli && pnpm testto verify cnc tests passNotes
@constructive-io/cliandpgpmfor the complete workflowcnc --helpshows only 4 commands,cnc deploycorrectly fails with "Unknown command"@pgpmjs/loggerand@pgpmjs/typesremain as dependencies in packages/cli - these are legitimately used by the GraphQL commands (server, explorer)Link to Devin run: https://app.devin.ai/sessions/e847fee58b144d5fa6a7c390d5d9b760
Requested by: Dan Lynch (@pyramation)