Design/updating ds page #281
Merged
+86
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-sc
requested review from
Copilot
and removed request for
Copilot and
joaquimds
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the design system to remove type-based colors and introduces customizable colors for markers, folders, and data sources. It also adds the ability to switch between cluster and heatmap display modes for marker data sources.
Changes:
- Added color customization for markers, placed markers, and folders with a new ColorPalette component
- Introduced marker display modes (clusters/heatmap) with visual toggle in context menus
- Redesigned DataSourceItem component with neutral color scheme and improved layout
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/models/Map.ts | Added MarkerDisplayMode enum and new optional config fields for colors and display modes |
| src/server/trpc/routers/map.ts | Updated config mutation to handle new color and display mode fields |
| src/components/ColorPalette.tsx | New component providing a color picker with 12 predefined colors |
| src/components/DataSourceItem.tsx | Redesigned UI with neutral colors, improved spacing, and sorted metadata display |
| src/app/map/[id]/components/controls/DataSourceItem.tsx | Added color picker and display mode toggle (cluster/heatmap) to context menu |
| src/app/map/[id]/components/controls/MarkersControl/SortableMarkerItem.tsx | Added color customization via context menu for individual markers |
| src/app/map/[id]/components/controls/MarkersControl/SortableFolderItem.tsx | Added folder color picker that propagates to all markers in the folder |
| src/app/map/[id]/components/controls/MarkersControl/MarkersList.tsx | Updated drag-and-drop to inherit folder colors and display custom colors in overlay |
| src/app/map/[id]/components/controls/MarkersControl/MarkerDragOverlay.tsx | Updated to display custom marker colors during drag operations |
| src/app/map/[id]/components/controls/ControlWrapper.tsx | Added support for custom colors via new color prop |
| src/app/map/[id]/components/PlacedMarkers.tsx | Updated to render markers with custom colors from config |
| src/app/map/[id]/components/Markers.tsx | Implemented heatmap display mode with custom color gradients and conditional rendering |
| src/app/(private)/data-sources/components/UserDataSourcesList.tsx | Updated to sort data sources by import date and simplified header styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Can It Be Tested?
How Will This Be Deployed?
Screenshots (if appropriate):
Types of changes
Checklist: