Upgrade ChiSqSelectorModel to spark 3.2.0 compatible design#815
Open
austinzh wants to merge 1 commit intocombust:masterfrom
Open
Upgrade ChiSqSelectorModel to spark 3.2.0 compatible design#815austinzh wants to merge 1 commit intocombust:masterfrom
austinzh wants to merge 1 commit intocombust:masterfrom
Conversation
austinzh
force-pushed
the
u/austinzh/MLPLAT-232-ChiSqSelectorModel
branch
2 times, most recently
from
3177553 to
dab4acf
Compare
sort filterIndiecs before using it
austinzh
force-pushed
the
u/austinzh/MLPLAT-232-ChiSqSelectorModel
branch
from
dab4acf to
5ce228d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing ChiSqSelectorModel assume filterIndiecs is sorted
But since spark 3.0.0, filterIndiecs is not sorted any more.
This PR simply sort the filterIndiecs and use it later.