feat(hawk-js): add setContext and setUser methods #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested changes
Oct 14, 2025
src/catcher.ts
Outdated
| * Clear current user information | ||
| */ | ||
| public clearUser(): void { | ||
| this.user = null; |
Member
There was a problem hiding this comment.
default user id should be generated in this case
src/catcher.ts
Outdated
Comment on lines
253
to
255
| public getCurrentUser(): AffectedUser | null { | ||
| return this.user; | ||
| } |
src/catcher.ts
Outdated
Comment on lines
276
to
278
| public getCurrentContext(): EventContext | undefined { | ||
| return this.context; | ||
| } |
Member
There was a problem hiding this comment.
I don't see any use case for that.
neSpecc
approved these changes
Oct 14, 2025
neSpecc
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: no simple way to update user and context data dynamically in runtime
Changes: implemented setContext and setUser methods