-
Notifications
You must be signed in to change notification settings - Fork 12
feat: hackathon submission - tag subscriber in kit #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Introduced a new section to display active hackathons associated with episodes, including title, deadline, sponsors, and a join button. - Updated the episode schema to include hackathon data retrieval. - Enhanced styling for the new hackathon card layout to improve visual presentation.
- Added new Kit integration with schema and steps for tagging subscribers. - Updated client and index files to include Kit schemas and functions. - Enhanced website integration to invoke the new tag subscriber function during relevant workflows. - Improved error handling and response structure in the Kit API functions.
- Removed console log from the tagSubscriber function. - Updated the tagSubscriber function to throw an error if tagName is not provided. - Changed the parameter used in the tagSubscriberKit function call from tag to tagName for consistency.
- Eliminated the 'log-the-output' step from the hackathon submission process to streamline the workflow. - This change enhances the clarity and efficiency of the integration without affecting functionality.
👷 Deploy request for codetv-automations pending review.Visit the deploys page to approve it
|
👷 Deploy request for codetv pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for codetv-links ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jlengstorf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great! I have one open question but I think this is looking good to go
| step: any; | ||
| }): Promise<{ subscription: any }> { | ||
| return await step.run('tag-subscriber', async () => { | ||
| return await tagSubscriberKit(event.data.email, event.data.tagName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be staring right at it, but what happens if this email is not subscribed? we probably need to check for that kind of failure and signal that it's non-retriable so Inngest doesn't keep retrying
Co-authored-by: Jason Lengstorf <[email protected]>
No description provided.