fix: apply community cloud filters and pagination on the featured view - #404
Closed
imantsk wants to merge 2 commits into
Closed
fix: apply community cloud filters and pagination on the featured view#404imantsk wants to merge 2 commits into
imantsk wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
doSearchcallback early-returned whenever the search query was empty — and the featured view is exactly the empty-query state. Every filter dropdown change and pagination click on the initial Featured Snippets page was silently dropped: no request, no state change. With a search term present the same controls worked, which is why the bug only showed on the default view.All other layers (WP REST
cloud/snippets/featured,Cloud_API::get_featured_snippets, the cloud/public/featuredendpoint) already accept and honourcategory/type/status— only the front-end guard blocked them.makeSearchRequestalready routes an empty query to the featured endpoint, so removing the guard restores filters, pagination, and empty-box submit on the featured view.Verified in the browser against the live cloud API: category/type/status filters narrow featured results (stacked filters included), featured pagination works, and the search-query path is unaffected.