Do not allow having both "id" and "@id" / type" and "@type" in Thing#76
Merged
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Member
|
|
Contributor
Author
Do you like me to remove it in this PR? |
Member
|
It can be a separate PR |
Merged
Contributor
Author
Created as #77 |
progval
force-pushed
the
not-both-id-type-in-thing
branch
from
cfe03df to
f1b8b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation for Thing to errors on having both "id" and "@id" / "type" and "@type".
Cypress tests added.
Should we also check for
codemeta:type? As it is mentioned here:codemeta-generator/js/validation/things.js
Line 15 in 504eca0