perf: resolve global lock contention in template server#2
Open
idogrady wants to merge 2 commits into
Open
Conversation
Replaces the global RwLock over the server sessions map with dashmap to provide highly concurrent bucket-level sharding. This removes the latency bottleneck where single ingest requests would block all other sessions. Fine-grained locking has also been added to SessionEntry.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the example server’s session storage to improve concurrency by replacing a globally locked HashMap with DashMap and moving locking to per-session fields.
Changes:
- Replace
Arc<RwLock<HashMap<...>>>session store withArc<DashMap<...>>. - Introduce per-session synchronization (
RwLockfor template index,Mutexfor last-touch timestamp). - Update routes and TTL sweeper to operate on the new session store.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/server/tests/integration.rs | Updates test state construction to use DashMap sessions. |
| examples/server/src/session.rs | Changes AppState.sessions type and adds per-session locks. |
| examples/server/src/routes.rs | Adjusts session lookup/insert and per-session locking around index/last_touch. |
| examples/server/src/main.rs | Updates TTL sweeper to retain entries directly in DashMap. |
| examples/server/Cargo.toml | Adds dashmap dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the global RwLock over the server sessions map with dashmap to provide highly concurrent bucket-level sharding. This removes the latency bottleneck where single ingest requests would block all other sessions. Fine-grained locking has also been added to SessionEntry.