posthog: flush telemetry before propagating a failed child's exit code#6
Open
NGHINAI wants to merge 1 commit into
Open
posthog: flush telemetry before propagating a failed child's exit code#6NGHINAI wants to merge 1 commit into
NGHINAI wants to merge 1 commit into
Conversation
`codag wrap -- <cmd>` propagated a failed child's exit code with a bare os.Exit inside runWrap. That skips the cli_command_completed event and the analytics.Shutdown() flush in Execute, so the PostHog queue (5s batch interval) silently drops cli_wrap_completed and cli_command_completed for exactly the runs where the child failed — in the dashboard those runs look like the CLI hung after cli_command_invoked. Record the exit code instead and os.Exit from Execute after the flush. Exit-code propagation is unchanged: child exit 7 still yields codag exit 7. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codag wrap -- <cmd>propagated a failed child's exit code with a bare os.Exit inside runWrap. That skips the cli_command_completed event and the analytics.Shutdown() flush in Execute, so the PostHog queue (5s batch interval) silently drops cli_wrap_completed and cli_command_completed for exactly the runs where the child failed — in the dashboard those runs look like the CLI hung after cli_command_invoked.Record the exit code instead and os.Exit from Execute after the flush. Exit-code propagation is unchanged: child exit 7 still yields codag exit 7.