Fix MCP server reporting hardcoded version instead of actual CLI version#2
Open
devangpratap wants to merge 1 commit into
Open
Fix MCP server reporting hardcoded version instead of actual CLI version#2devangpratap wants to merge 1 commit into
devangpratap wants to merge 1 commit into
Conversation
The MCP initialize response had the server version hardcoded as "0.1.5". This wires cmd.Version into the mcp package so the reported version stays in sync with releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1.
The MCP
initializeresponse had the server version hardcoded as"0.1.5". The actual CLI version is injected via ldflags intocmd.Version, but the MCP server never read it. So every release since 0.1.5 has been telling MCP clients the wrong version.This adds a package-level
Versionvar tointernal/mcpand sets it from thecmdpackage beforeServe()runs. Falls back to"dev"for local builds.