Skip to content

Display contributor image#231

Open
KVGarg wants to merge 1 commit intocoala:masterfrom
KVGarg:contributors-image
Open

Display contributor image#231
KVGarg wants to merge 1 commit intocoala:masterfrom
KVGarg:contributors-image

Conversation

@KVGarg
Copy link
Contributor

@KVGarg KVGarg commented Feb 4, 2019

This enhancement commit displays the contributor image
along with the information on the community website.

Closes #139, Closes #141

@TravisBuddy

This comment has been minimized.

@TravisBuddy

This comment has been minimized.

@TravisBuddy

This comment has been minimized.

@TravisBuddy

This comment has been minimized.

Copy link

@frextrite frextrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KVGarg The commit message is still not changed even after @jayvdb's review. Please look into it.

@KVGarg
Copy link
Contributor Author

KVGarg commented Feb 12, 2019

@frextrite I have already changed commit message 4 days ago. The moment @jayvdb asked me to change the commit message 👍
I have changed the commit message from web only, by choosing edit message option, instead of changing through git terminal

@Naveenaidu
Copy link
Member

Naveenaidu commented Feb 12, 2019

@KVGarg

I have changed the commit message from web only, by choosing edit message option, instead of changing through git terminal

You might have misinterpreted the heading of the PR with the commit message. In fact, you cannot change the commit message via Github. The reason being the hash for every Git commit is also calculated based on the commit message. When you change the commit message, you change the commit hash. If you want to push that commit, you have to force that push . Which is not possible via Github. In short - You cannot change the commit message using the Github Interface.

Please use git commit --amend in your terminal to update your message.

And the details

This enhancement commit displays the contributor image
along with the information on the [community website](http://community.coala.io/contributors/).

Closes #139 and #141

Should be added while you make changes into the commit message.

@KVGarg
Copy link
Contributor Author

KVGarg commented Feb 12, 2019

Ok @Naveenaidu I will make that change via terminal

@TravisBuddy

This comment has been minimized.

@bkhanale
Copy link
Member

@KVGarg See this and update your commit body.

@KVGarg KVGarg force-pushed the contributors-image branch from 3fe9072 to 8f56944 Compare February 12, 2019 11:58
@TravisBuddy

This comment has been minimized.

@KVGarg
Copy link
Contributor Author

KVGarg commented Feb 12, 2019

@bkhanale This isn't getting changed. Tried ways of doing this

@TravisBuddy

This comment has been minimized.

@TravisBuddy

This comment has been minimized.

@TravisBuddy
Copy link

Travis tests have failed

Hey @KVGarg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

coala --non-interactive -V
[ERROR][13:22:01] There is a conflict in the version of a dependency you have installed and the requirements of coala. This may be resolved by creating a separate virtual environment for coala or running `pip3 install "git-url-parse~=1.1.0"`. Be aware that the latter solution might break other python packages that depend on the currently installed version.
[INFO][13:22:01] Exception was:
Traceback (most recent call last):

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/coala_main.py", line 147, in run_coala
    args=args)

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/settings/ConfigurationGathering.py", line 504, in gather_configuration
    targets=targets,

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/settings/SectionFilling.py", line 97, in fill_settings
    bear_dirs = section.bear_dirs()

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/settings/Section.py", line 147, in bear_dirs
    for bear_dir in collect_registered_bears_dirs('coalabears')]

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/collecting/Collectors.py", line 456, in collect_registered_bears_dirs
    registered_package = ep.load()

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2404, in load
    self.require(*args, **kwargs)

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2427, in require
    items = working_set.resolve(reqs, env, installer, extras=self.extras)

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/pkg_resources/__init__.py", line 875, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)

pkg_resources.VersionConflict: (git-url-parse 1.2.0 (/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages), Requirement.parse('git-url-parse~=1.1.0'))
TravisBuddy Request Identifier: 367ebad0-2ec9-11e9-9ea4-33062c9ac3a7

Copy link

@frextrite frextrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netlify preview is failing. Can you check if the build failure is related to the changes or not?

@KVGarg
Copy link
Contributor Author

KVGarg commented Feb 13, 2019

@frextrite the build failure isn’t related to my changes. Earlier it was green, the moment i created this PR but I have no idea why it turned red after yesterday chabges in commit messgae. The netlify buidl is green on my branch, will re-push the changes soon.

@TravisBuddy

This comment has been minimized.

@KVGarg
Copy link
Contributor Author

KVGarg commented Mar 3, 2019

Re-pushed changes to avoid git-url-parse build error. Travis CI failing due to moban

@TravisBuddy

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.