Skip to content

[mini2mini] Add and PATIsolatedTrackRekeyer#50827

Draft
battibass wants to merge 1 commit intocms-sw:masterfrom
battibass:mini2mini_isotrack_rekeyer
Draft

[mini2mini] Add and PATIsolatedTrackRekeyer#50827
battibass wants to merge 1 commit intocms-sw:masterfrom
battibass:mini2mini_isotrack_rekeyer

Conversation

@battibass
Copy link
Copy Markdown

@battibass battibass commented Apr 29, 2026

PR description:

This PR aims to reduce the number of discrepancies that arise when comparing NANO AOD samples produced from MiniAOD v2/v4, depending on whether intermediate MiniAOD v6 are persisted.

PR validation:

Variable-by-variable comparison of NANO AOD quantities from files produced running the two above-mentioned workflows on the same initial sample.

Will actually add results when moving this draft into an sctual PR

@cmsbuild cmsbuild added this to the CMSSW_17_0_X milestone Apr 29, 2026
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 29, 2026 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 29, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50827/49170

@ftorrresd
Copy link
Copy Markdown
Contributor

ftorrresd commented Apr 29, 2026

enable nano

@ftorrresd
Copy link
Copy Markdown
Contributor

ftorrresd commented Apr 29, 2026

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 29, 2026

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b45ee7/52943/summary.html
COMMIT: ed79751
CMSSW: CMSSW_17_0_X_2026-04-29-1100/el8_amd64_gcc13
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50827/52943/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4186963
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4186918
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.0001 3.094 3.094 0.000 ( +0.0% ) 2.98 3.76 -20.7% 2.669 2.692
NANOmc106Xul16APVv2 2500.0002 3.048 3.048 0.000 ( +0.0% ) 3.00 3.81 -21.1% 2.631 2.713
NANOmc106Xul17v2 2500.0003 3.153 3.153 0.000 ( +0.0% ) 2.83 3.52 -19.5% 2.671 3.135
NANOmc106Xul18v2 2500.0004 3.105 3.105 0.000 ( +0.0% ) 2.85 3.54 -19.6% 2.674 3.122
NANOdata106Xul16v2 2500.0101 1.540 1.540 0.000 ( +0.0% ) 4.77 6.27 -23.9% 2.811 2.807
NANOdata106Xul17v2 2500.0102 1.926 1.926 0.000 ( +0.0% ) 3.30 4.14 -20.3% 2.506 2.997
NANOdata106Xul18v2 2500.0103 1.890 1.890 0.000 ( +0.0% ) 3.90 4.96 -21.3% 2.866 2.884
NANOmcUL16APVreMINI 2500.0201 0.022 0.022 0.000 ( +0.0% ) 1.36 1.85 -26.1% 2.949 2.628
NANOmcUL16reMINI 2500.0202 0.022 0.022 0.000 ( +0.0% ) 1.34 1.82 -26.1% 2.967 2.645
NANOmcUL17reMINI 2500.0203 0.022 0.022 0.000 ( +0.0% ) 1.10 1.65 -33.0% 2.395 3.103
NANOmcUL18reMINI 2500.0204 0.022 0.022 0.000 ( +0.0% ) 1.13 1.59 -29.3% 2.842 2.829
NANOdataUL16APVreMINI 2500.0301 0.035 0.035 0.000 ( +0.0% ) 1.12 1.56 -28.6% 2.706 2.725
NANOdataUL16reMINI 2500.0302 0.036 0.036 0.000 ( +0.0% ) 1.15 1.59 -27.3% 2.626 2.639
NANOdataUL17reMINI 2500.0303 0.037 0.037 0.000 ( +0.0% ) 1.13 1.50 -24.5% 2.748 2.744
NANOdataUL18reMINI 2500.0304 0.036 0.036 0.000 ( +0.0% ) 1.06 1.51 -29.6% 2.752 2.728
NANOmcUL16APVMini2Mini 2500.0401 0.023 0.023 0.000 ( +0.0% ) 1.84 2.53 -27.2% 2.253 2.241
NANOmcUL16Mini2Mini 2500.0402 0.023 0.023 0.000 ( +0.0% ) 1.78 2.45 -27.4% 2.114 2.167
NANOmcUL17Mini2Mini 2500.0403 0.023 0.023 0.000 ( +0.0% ) 1.73 2.44 -29.0% 2.239 2.244
NANOmcUL18Mini2Mini 2500.0404 0.023 0.023 0.000 ( +0.0% ) 1.76 2.45 -28.2% 2.242 2.200
NANOdataUL16Mini2Mini 2500.0501 0.039 0.039 0.000 ( +0.1% ) 2.65 3.55 -25.4% 1.993 2.022
NANOdataUL17Mini2Mini 2500.0502 0.040 0.040 0.000 ( +0.0% ) 1.91 2.58 -26.1% 2.085 2.094
NANOdataUL18Mini2Mini 2500.0503 0.040 0.039 0.000 ( +0.1% ) 2.22 3.04 -27.1% 2.083 2.097
NANOmc130X 2500.1001 3.228 3.228 0.000 ( +0.0% ) 3.32 4.20 -20.9% 2.386 2.393
NANOdata130Xrun3 2500.1101 1.790 1.790 0.000 ( +0.0% ) 4.91 6.43 -23.6% 2.548 2.652
NANOmc23Mini2Mini 2500.1201 0.022 0.022 0.000 ( +0.0% ) 2.16 2.73 -20.8% 1.709 2.014
NANOdata23Mini2Mini 2500.1301 0.041 0.041 0.000 ( +0.0% ) 2.62 3.66 -28.3% 2.305 2.411
ScoutingNANOdata124Xrun3 2500.1501 0.772 0.772 0.000 ( +0.0% ) 26.19 34.22 -23.5% 1.452 1.460
ScoutingNANOmonitordata124Xrun3 2500.1502 0.862 0.862 0.000 ( +0.0% ) 10.73 14.20 -24.5% 1.379 1.466
ScoutingNANOdata130Xrun3 2500.1503 1.251 1.251 0.000 ( +0.0% ) 19.54 25.19 -22.4% 1.544 1.420
ScoutingNANOmonitordata130Xrun3 2500.1504 1.297 1.297 0.000 ( +0.0% ) 8.62 11.22 -23.2% 1.341 1.342
muPOGNANOmc140X 2500.2201 2.269 2.269 0.000 ( +0.0% ) 4.16 5.44 -23.6% 2.131 2.123
EGMNANOmc140X 2500.2202 3.859 3.859 0.000 ( +0.0% ) 3.02 4.02 -25.0% 2.357 2.411
BTVNANOmc140X 2500.2203 10.475 10.475 0.000 ( +0.0% ) 1.89 2.56 -26.2% 2.459 2.069
jmeNANOmc140X 2500.2204 6.639 6.639 0.000 ( +0.0% ) 0.90 1.15 -22.4% 2.057 2.538
lepTrackInfoNANOmc140X 2500.2206 3.553 3.553 0.000 ( +0.0% ) 2.94 4.05 -27.5% 2.232 2.443
ScoutingNANOmc140X 2500.2207 1.488 1.488 0.000 ( +0.0% ) 10.44 14.36 -27.2% 1.784 1.786
ScoutingNANOwithPromptmc140X 2500.2208 4.461 4.461 0.000 ( +0.0% ) 2.68 3.19 -16.0% 2.706 2.609
muPOGNANO140Xrun3 2500.2301 1.683 1.683 0.000 ( +0.0% ) 5.66 7.81 -27.5% 2.340 2.338
EGMNANOdata140Xrun3 2500.2302 2.623 2.623 0.000 ( +0.0% ) 4.18 5.79 -27.7% 2.672 2.702
BTVNANOdata140Xrun3 2500.2303 5.612 5.612 0.000 ( +0.0% ) 2.80 3.72 -24.9% 2.873 2.549
jmeNANOdata140Xrun3 2500.2304 3.976 3.976 0.000 ( +0.0% ) 1.17 1.46 -19.8% 2.408 2.408
lepTrackInfoNANOdata140Xrun3 2500.2306 2.413 2.413 0.000 ( +0.0% ) 4.56 5.81 -21.6% 2.655 2.310
ScoutingNANOdata140Xrun3 2500.2307 1.101 1.101 0.000 ( +0.0% ) 25.36 30.10 -15.7% 1.424 1.433
ScoutingNANOmonitordata140Xrun3 2500.2308 2.784 2.784 0.000 ( +0.0% ) 4.43 5.10 -13.2% 2.597 2.521
ScoutingNANOmonitorWithPromptdata140Xrun3 2500.2309 2.784 2.784 0.000 ( +0.0% ) 4.41 5.11 -13.6% 2.671 2.518
L1ScoutingSelectionNANOdata140Xrun3 2500.2311 0.081 0.081 0.000 ( +0.0% ) 33.29 48.13 -30.8% 0.843 0.839
L1ScoutingNANOdata140Xrun3 2500.231 0.082 0.082 0.000 ( +0.0% ) 3.37 4.10 -17.7% 0.640 0.829
l1DPGNANO140Xrun3 2500.2401 9.405 9.405 0.000 ( +0.0% ) 4.62 6.85 -32.6% 1.744 1.766
muDPGNANO140Xrun3 2500.2402 10.377 10.377 0.000 ( +0.0% ) 1.23 1.57 -22.0% 1.596 1.622
muDPGNANOBkg140Xrun3 2500.2403 6.401 6.401 0.000 ( +0.0% ) 11.22 14.69 -23.7% 1.220 1.218
hcalDPGNANO140Xrun3 2500.2404 486.015 486.015 0.000 ( +0.0% ) 0.90 1.16 -22.9% 1.631 1.585
hcalDPGCalibNANO140Xrun3 2500.2405 826.418 826.418 0.000 ( +0.0% ) 1.21 1.53 -20.6% 1.573 1.560
hcalDPGMCNANO140Xrun3 2500.2501 645.333 645.333 0.000 ( +0.0% ) 1.27 1.65 -23.0% 1.656 1.717
NANOmc2024reMINI 2500.2601 0.021 0.021 0.000 ( +0.0% ) 1.65 1.91 -13.4% 2.742 2.484
NANOdata2024reMINI 2500.2701 0.036 0.036 0.000 ( +0.0% ) 1.51 1.88 -19.7% 2.605 2.447
NANOmc150X 2500.3001 3.224 3.224 0.000 ( +0.0% ) 15.64 17.87 -12.5% 2.775 2.755
NANOdata150X 2500.3101 2.144 2.144 0.000 ( +0.0% ) 29.74 34.54 -13.9% 2.297 2.284
NANOdata150X 2500.3102 2.630 2.630 0.000 ( +0.0% ) 24.76 28.19 -12.2% 2.286 2.304
muPOGNANOmc150X 2500.3201 2.344 2.344 0.000 ( +0.0% ) 13.71 16.47 -16.8% 2.390 2.425
EGMNANOmc150X 2500.3202 4.118 4.118 0.000 ( +0.0% ) 12.29 14.91 -17.6% 2.495 2.571
BTVNANOmc150X 2500.3203 10.559 10.559 0.000 ( +0.0% ) 4.13 4.91 -15.8% 2.709 2.769
jmeNANOmc150X 2500.3204 6.460 6.460 0.000 ( +0.0% ) 1.19 1.36 -12.0% 2.740 2.082
jmeNANOrePuppimc150X 2500.3205 6.464 6.464 0.000 ( +0.0% ) 1.13 1.27 -11.5% 2.997 2.444
lepTrackInfoNANOmc150X 2500.3206 3.728 3.728 0.000 ( +0.0% ) 13.09 15.02 -12.9% 2.544 1.940
ScoutingNANOmc150X 2500.3207 1.563 1.563 0.000 ( +0.0% ) 18.10 20.13 -10.1% 2.309 2.274
ScoutingNANOwithPromptmc150X 2500.3208 4.781 4.781 0.000 ( +0.0% ) 9.82 10.63 -7.6% 2.736 2.854
BPHNANOmc150X 2500.3209 4.135 4.135 0.000 ( +0.0% ) 15.53 17.29 -10.2% 2.811 2.269
muPOGNANO150Xrun3 2500.3301 1.244 1.244 0.000 ( +0.0% ) 26.74 29.74 -10.1% 2.183 2.158
EGMNANOdata150Xrun3 2500.3302 2.985 2.985 0.000 ( +0.0% ) 23.06 26.85 -14.1% 2.442 2.249
BTVNANOdata150Xrun3 2500.3303 7.971 7.971 0.000 ( +0.0% ) 5.54 6.05 -8.4% 2.531 2.130
jmeNANOdata150Xrun3 2500.3304 4.349 4.349 0.000 ( +0.0% ) 1.51 1.67 -9.7% 2.507 2.048
jmeNANOrePuppidata150Xrun3 2500.3305 4.332 4.332 0.000 ( +0.0% ) 1.30 1.45 -10.3% 2.640 2.299
lepTrackInfoNANOdata150Xrun3 2500.3306 2.625 2.625 0.000 ( +0.0% ) 25.54 28.76 -11.2% 2.251 1.980
ScoutingNANOdata150Xrun3 2500.3307 1.738 1.738 0.000 ( +0.0% ) 29.14 32.36 -9.9% 1.507 1.628
ScoutingNANOmonitordata150Xrun3 2500.3308 1.400 1.400 0.000 ( +0.0% ) 24.82 27.63 -10.1% 2.153 2.141
ScoutingNANOmonitorWithPromptdata150Xrun3 2500.3309 2.602 2.602 0.000 ( +0.0% ) 16.38 18.00 -9.0% 2.496 2.604
L1ScoutingNANOdata150Xrun3 2500.3311 0.078 0.078 0.000 ( +0.0% ) 3.34 3.53 -5.6% 0.953 0.956
L1ScoutingSelectionNANOdata150Xrun3 2500.3312 0.078 0.078 0.000 ( +0.0% ) 25.47 26.58 -4.2% 0.977 0.969
BPHNANOdata150Xrun3 2500.331 2.632 2.632 0.000 ( +0.0% ) 29.63 33.93 -12.7% 2.326 2.324
L1ScoutingNANOdata160Xrun3 2500.4301 0.110 0.110 0.000 ( +0.0% ) 2.03 2.13 -4.5% 0.933 0.932
L1ScoutingSelectionNANOdata160Xrun3 2500.4302 0.113 0.113 0.000 ( +0.0% ) 16.68 19.15 -12.9% 0.967 0.963
TTbarMINIAOD10.6_UL18v2 2500.9001 1.814 1.814 0.000 ( +0.0% ) 32.54 35.19 -7.5% 1.915 1.906
TTbarMINIAOD14.0 2500.9002 1.662 1.662 0.000 ( +0.0% ) 30.93 34.82 -11.2% 1.504 1.497
DYToLL_M-50_13TeV_pythia8 2500.9101 14.992 14.992 0.000 ( +0.0% ) 6.03 8.30 -27.4% 1.159 1.151
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.9102 0.310 0.150 0.161 ( +107.4% ) 2.86 2.33 +23.1% 0.890 0.891
TTbar_Pow_LHE_13TeV 2500.9103 0.110 0.110 0.000 ( +0.0% ) 2.24 2.51 -10.6% 0.893 0.893

NANO Comparison Summary

Summary:

  • You potentially added 1209 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 144 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 43020
  • DQMHistoTests: Total failures: 144
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 42876
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 189 log files, 110 edm output root files, 32 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code-checks-approved orp-pending pending-signatures reconstruction-pending tests-approved xpog-pending

Projects

None yet

Milestone

CMSSW_17_0_X

Development

Successfully merging this pull request may close these issues.

3 participants

@battibass @cmsbuild @ftorrresd