Skip to content

Simplify LST input & output and some clean up of the HLT tracking-related sequence.#50819

Open
VourMa wants to merge 4 commits intocms-sw:masterfrom
SegmentLinking:simplifyLSTInputOutput
Open

Simplify LST input & output and some clean up of the HLT tracking-related sequence.#50819
VourMa wants to merge 4 commits intocms-sw:masterfrom
SegmentLinking:simplifyLSTInputOutput

Conversation

@VourMa
Copy link
Copy Markdown
Contributor

@VourMa VourMa commented Apr 27, 2026

This is a technical PR, aiming to simplify and speed up the input and output of the LST algorithm. The physics performance has been verified to remain unchanged while the following small timing improvements were observed for the HLT:

  • hltInitialStepSeedTracksLST: 4.6 → 0 ms (-100%);
  • hltInputLST: 18.5 → 16.2 ms (-12%);
  • LSTOutputConverter: 67.9 → 55.4 ms (-18%).

As collateral developments of this PR:

  • some redundant tracking modules were removed from the HLT tracking sequence;
  • the explicit definition of a couple muon modules was completed (previously they were lacking a few parameters);
  • two functionalities were added to the creation of seed from tracks for further study in the future (sorting and filtering of hits and removal of OT hits when the track kinematics are used).

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 27, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50819/49145

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @VourMa for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoTracker/IterativeTracking (reconstruction)
  • RecoTracker/LST (reconstruction)
  • RecoTracker/TkSeedGenerator (reconstruction)

@Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @SohamBhattacharya, @VinInn, @VourMa, @dgulhan, @elusian, @felicepantaleo, @gpetruc, @missirol, @mmasciov, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Copy Markdown
Contributor

test parameters:

  • enable = hlt_p2_integration, hlt_p2_timing
  • workflows = ph2_hlt

@Martin-Grunewald
Copy link
Copy Markdown
Contributor

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: HLTP2Timing
Size: This PR adds an extra 72KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fbb6b/52908/summary.html
COMMIT: 0c81f3f
CMSSW: CMSSW_17_0_X_2026-04-27-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50819/52908/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 68
  • DQMHistoTests: Total histograms compared: 4803216
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4803180
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 67 files compared)
  • Checked 284 log files, 246 edm output root files, 68 DQM output files
  • TriggerResults: found differences in 19 / 66 workflows

@slava77
Copy link
Copy Markdown
Contributor

slava77 commented Apr 28, 2026

Failed Tests: HLTP2Timing

Looking at the log it's unclear what actually failed.
There are lines like

runHLTTiming.sh: line 151: 3059765 Terminated              tail -f "$TMP_LOG_FILE"

but the text around looks OK

VourMa added 4 commits May 4, 2026 06:10
- Add flags for tracking/seeding production

- Conditional creation of products

- Per-iteration heap allocations moved out of the loop

- Remove unnecessary OT hit loop + sort for pLS candidates
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50819/49223

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

Pull request #50819 was updated. @Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @srimanob can you please check and sign again.

@slava77
Copy link
Copy Markdown
Contributor

slava77 commented May 4, 2026

please test with #50867

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fbb6b/53048/summary.html
COMMIT: 64bf303
CMSSW: CMSSW_17_0_X_2026-05-03-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50819/53048/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 68
  • DQMHistoTests: Total histograms compared: 4803421
  • DQMHistoTests: Total failures: 861
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4802540
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 67 files compared)
  • Checked 284 log files, 246 edm output root files, 68 DQM output files
  • TriggerResults: found differences in 18 / 66 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants