-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[go-migration] add cf-metrics-exporter framework #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/go-migration
Are you sure you want to change the base?
[go-migration] add cf-metrics-exporter framework #1149
Conversation
…ture/go-migration
…ture/go-migration
…ture/go-migration
…ture/go-migration
| } | ||
|
|
||
| port := j.getPort() | ||
| return fmt.Sprintf("jmx=%d", port), nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are these changes related to the introduction of the cf_metrics_exporter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I will remove this change from this PR.
Can be put in another PR if appropriate:
Background: implementing the Detect() method for cf-metrics-exporter I found that JMX returns a different kind of name than all other frameworks listed in the detected frameworks:
Detected frameworks: [Java CF Env Client Certificate Mapper Container Security Provider CF Metrics Exporter jmx=5000 Java Opts]
Changed "jmx=5000" to "JMX" as Detect returned framework name.
…ture/go-migration
|
im wondering if we need to add a integration test for this. |
…ture/go-migration
@ramonskie I will have a look if I can add an integration test for this |
fixes #1138