Support github actions with Windows 10 SDK and VS 2022 (v143) #50
+144
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio 2022 or later cannot build the current version of UtilsActions project, because of the type errors. Having these UtilsActions.dll binaries is actually beneficial as there is no more need of the UtilsActions project, at the expense of not being able to modify those methods if needed. But the UtilsActions.dll methods are rather fixed in their purpose and should not change for the foreseeable future. If, for any reason, there is the need to change those methods, the project will need to be rewritten. Currently, the rewrite is not needed, thus this addition. ``` std::wstring GenerateRandomPassword(); void GetUserSid(const std::wstring& username, PSID &pSid); std::vector<std::wstring> GetUserRights(const std::wstring& username); void AssignUserRights(const std::wstring& username, const std::vector<std::wstring> rights); ``` Signed-off-by: Adrian Vladu <[email protected]>
Signed-off-by: Adrian Vladu <[email protected]>
This reverts commit 88b1938.
Signed-off-by: Adrian Vladu <[email protected]>
ader1990
force-pushed
the
add_support_for_github_actions_build_with_utilsactions
branch
from
210ffc2 to
a3a7a0f
Compare
Member
There was a problem hiding this comment.
Since you're fixing the utils compilation, why do we need to include the DLLs?
Member
Author
There was a problem hiding this comment.
The msms were added to keep backwards compatibility in the sense of codebase, but I need to check if they are still required and for what version of VS and SDK. For example, if we want to only support VS 2022 or VS 2017 and 2019 and 2022, I need to verify more.
Signed-off-by: Adrian Vladu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.