Allow smoketests to use a custom CLI#5462
Open
clockwork-labs-bot wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Closing this because SpacetimeDBPrivate #3250 no longer updates the public submodule or depends on this smoketest helper. The cross-commit test now keeps the CLI-path override local to the private test. |
bfops
reviewed
Jun 29, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
clockwork-labs-bot
requested review from
cloutiertyler and
jdetter
as code owners
clockwork-labs-bot
changed the title
This reverts commit 2aa5b8c.
clockwork-labs-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a
SmoketestBuilder::cli_pathoverride so tests can exercise the standard smoketest helpers with a specific prebuilt CLI binary. The default behavior is unchanged and still uses the prebuilt CLI discovered byspacetimedb_guard.API and ABI breaking changes
None.
Expected complexity level and risk
Testing
PATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH /Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/cargo check -p ciPATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH /Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/cargo check -p spacetimedb-smoketests