Fix C# + C++ SDKs for making Options filterable and expand sdk-test#5461
Open
JasonAtClockwork wants to merge 5 commits into
Open
Fix C# + C++ SDKs for making Options filterable and expand sdk-test#5461JasonAtClockwork wants to merge 5 commits into
Options filterable and expand sdk-test#5461JasonAtClockwork wants to merge 5 commits into
Conversation
gefjon
approved these changes
Jun 30, 2026
gefjon
left a comment
Contributor
There was a problem hiding this comment.
I don't feel entirely qualified to review the implementation, but the tests look reasonable, and that's enough to convince me. It looks like you've missed committing some generated files, as the git tree check part of CI is failing. Otherwise, if you want to wait for @lisandroct 's review, I support that, but if you want to merge, go ahead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Options filterable on clients, and add SDK tests. #5448 expanding the tests to TS/C#/C++sdk-test-ts,sdk-test-cs, andsdk-test-cppto match Rust version; a couple changes were necessary to allow the codegen to work:std::optional<T>as filterableIsEquatable()Nullable<T>doesn't supportOption<T>index tables and reducers used by the SDK testsAPI and ABI breaking changes
Expected complexity level and risk
3 - Mostly test coverage and generated binding updates, with small changes to allow this properly in C++ and C#
Testing
sdk-testsuite