Skip to content

Fix release notification workflow startup#5394

Merged
bfops merged 2 commits into
masterfrom
bot/fix-release-notifications
Jun 18, 2026
Merged

Fix release notification workflow startup#5394
bfops merged 2 commits into
masterfrom
bot/fix-release-notifications

Conversation

@clockwork-labs-bot

Copy link
Copy Markdown
Contributor

Description of Changes

Fixes the Release Notifications workflow startup failure seen in https://github.com/clockworklabs/SpacetimeDB/actions/runs/27775721225/workflow.

The internal announcement job referenced needs: on-release, but no on-release job exists in .github/workflows/tag-release.yml, so the workflow failed before scheduling any jobs. This removes the dangling dependency and gates the internal Discord announcement to real release events so manual workflow_dispatch dry runs do not try to send an internal release announcement using missing release-event fields.

API and ABI breaking changes

None. This only changes GitHub Actions configuration.

Expected complexity level and risk

1 - Low complexity. The change is limited to one workflow job dependency/condition.

Testing

  • Parsed .github/workflows/tag-release.yml as YAML.
  • Checked that all remaining needs: targets in .github/workflows/tag-release.yml refer to existing jobs.
  • Ran git diff --check.
  • Optional reviewer check: run the workflow manually with the default dry-run inputs after merge.

@bfops bfops left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/workflows/tag-release.yml Outdated
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
@bfops bfops added this pull request to the merge queue Jun 18, 2026
Merged via the queue into master with commit e357f5a Jun 18, 2026
60 of 61 checks passed
@bfops bfops deleted the bot/fix-release-notifications branch June 18, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants