Skip to content

CI - Close some gaps with GitHub discord notifications#5056

Merged
bfops merged 4 commits into
masterfrom
bfops/notify-on-push
Jun 23, 2026
Merged

CI - Close some gaps with GitHub discord notifications#5056
bfops merged 4 commits into
masterfrom
bfops/notify-on-push

Conversation

@bfops

@bfops bfops commented May 16, 2026

Copy link
Copy Markdown
Collaborator

Description of Changes

We currently have discord notifications when PRs merge into master. We have two problems:

  1. These notifications don't run properly for external PRs (due to missing secrets)
  2. We don't get notifications for other pushes to master

This PR fixes those issues by changing the job to run on any push to master rather than when a PR is closed.

API and ABI breaking changes

None. CI only.

Expected complexity level and risk

1

Testing

I don't think we can test this without merging into master.

Comment thread .github/workflows/discord-posts.yml Outdated
@bfops bfops marked this pull request as ready for review June 23, 2026 19:03
@bfops bfops marked this pull request as draft June 23, 2026 19:07
@bfops bfops marked this pull request as ready for review June 23, 2026 19:10
@bfops bfops changed the title CI - Better discord notifications on pushes to master CI - Close some gaps with GitHub discord notifications Jun 23, 2026

@jdetter jdetter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, let's try it 👍

@bfops bfops added this pull request to the merge queue Jun 23, 2026
Merged via the queue into master with commit 2deba15 Jun 23, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants