Open
Conversation
Owner
|
Thanks for good suggestion. This plugin intends to support Commonmark syntax to DW, but not vice versa. As you mentioned, setting image attributes by Commonmark markup is not supported. Using HTML tag is recommended, but not a suitable solution to DW usages. Appending attributes in URL is one good way to implement such features for internal image link, but I think it has uncertainty in external images, because the URL query strings are unpredictable. Instead, I think following two alternatives would be better, based on your suggestion:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One limitation of this plugin in contrast to dokuwiki's native markup is that images can't be aligned. This pull request adds another image query parameter for image alignment, which is then translated to dokuwiki's image alignment by adding spaces before or after the image url.
For example
is translated into{{ test.jpg?align=right}}. The parameter itself is then ignored by dokuwiki.Image alignment in commonmark seems to be a controversial topic and my approach is adding a behavior that is not compatible with regular commonmark. I don't see any harm in doing this, since other dokuwiki specific query parameters (such as width and nolink) are also supported. But maybe this change is not desired.