Feat: Add gofmt formatting check support for Windows in CI - #254
Feat: Add gofmt formatting check support for Windows in CI#254Thedarkmatter10 wants to merge 1 commit into
Conversation
|
@giornetta The Windows run failed due to formatting issues caused by the addition of`gofmt -l . ; To fix this, I ran gofmt -w . ., which reformatted the files. As a result, version control now shows changes in many files. I'm unsure whether I should commit these changes or not. Please help what i can do ? |
|
@Thedarkmatter10 huh, looks like Windows line endings are not making gofmt happy. I'm not sure what we can do or if investigating this is even worth the effort to be honest. Windows can be such a pain to work with. |
|
@giornetta I think one possible solution will be the updated code i.e after formatting. First can merge after that this pr because issue is in formatting only right . May be it is possible solution. Can we test ? And submit the second PR what's your thought ? |
|
@Thedarkmatter10 I don't think that would be a viable solution, since Windows and Linux use different line endings for files and we definitely do not want all files to be converted to Windows-style line endings, imho. |
|
@giornetta then what's next ? |
@giornetta as per suggestion to create for windows support i have created a look pls.
What This PR Adds
This PR enhances the GitHub Actions CI pipeline by adding Windows support for gofmt formatting checks, ensuring consistency across platforms.
Summary of Changes
gofmt -lcheck using PowerShellgofmt -w🖥️ Test Output (Local Verification on Windows) with sample unformatted code.
❌ Before Formatting