feat: add LogsCollectorEnabled field to KubernetesClusterConfig civo/cli #485 Update fake_client.go - #239
Open
yuvarajrece wants to merge 3 commits into
Open
feat: add LogsCollectorEnabled field to KubernetesClusterConfig civo/cli #485 Update fake_client.go#239yuvarajrece wants to merge 3 commits into
yuvarajrece wants to merge 3 commits into
Conversation
[Enhancement] Update fake client to match the actual API behaviour for ResizeVolume method civo#233 Updated `ResizeVolume` to simulate real API errors like `VolumeResizeOnlineError`, size constraints, and retry failures.
Added LogsCollectorEnabled field to control logs collector installation.
yuvarajrece
changed the title
yuvarajrece
changed the title
yuvarajrece
changed the title
Author
|
@alessandroargentieri Kindly review the pr and approve it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
LogsCollectorEnabled *boolfield toKubernetesClusterConfigsoAPI consumers (starting with civo/cli) can explicitly enable or disable the
logs collector when creating a Kubernetes cluster.
Used as a pointer so "not set" (nil, omitted from the request) can be
distinguished from an explicit
true/false, letting the API's owndefault apply when the caller doesn't specify a value.
This is a prerequisite for civo/cli#485, which adds a
--logs-collector-enabledCLI flag and auto-disables the logs collectorby default on standard small/xsmall nodes to save node resources.
Related: civo/cli#485
[Enhancement] Update fake client to match the actual API behaviour for ResizeVolume method #233
Updated
ResizeVolumeto simulate real API errors likeVolumeResizeOnlineError, size constraints, and retry failures.