fix frametimes for relax plays#153
Open
dz-ss wants to merge 19 commits intocircleguard:masterfrom
Open
Conversation
removes consecutive short frametimes caused by relax mod and switching desktops during a break
Liam-DeVoe
reviewed
Jun 25, 2020
Contributor
|
I think the method could be written a little more elegantly but I like the direction. Can you upload a few relax plays to I also made this only run on relax plays, which I think I'll change because it would fix desktop tabbing out and I can't think of any potential for abuse here. If you have a replay of that occurring, I'd appreciate the upload as well (though I'll try and replicate myself). I'm unsure about filtering all 0 frame times. I would think that just looking at runs of short time frames would be enough. |
I know it was verbose so we didn't confuse it with legit plays but I don't think that's an issue when we have a `legit` folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes consecutive short frametimes caused by relax mod and switching desktops during a break