fix: make APP_FEE_RECIPIENT optional with conditional customFee - #6
Open
Sertug17 wants to merge 1 commit into
Open
fix: make APP_FEE_RECIPIENT optional with conditional customFee#6Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
APP_FEE_RECIPIENT was required in the Zod schema, but the README instructs users to leave it blank and run wallet:generate to populate it. If the wallet generation step is skipped, the app crashes at startup with a validation error. Made the field optional in the schema and only include customFee in the swap config when APP_FEE_RECIPIENT is set. This way the app starts without a fee recipient and swaps still work — just without collecting platform fees until one is configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APP_FEE_RECIPIENT was required in the Zod schema, but the README instructs users to leave it blank and run wallet:generate to populate it. If that step is skipped, the app crashes at startup with a validation error.
Changes: