Skip to content

Add $t to possible functions in preferences file - #3

Open
unamix wants to merge 3 commits into
christofferok:masterfrom
unamix:patch-1
Open

Add $t to possible functions in preferences file#3
unamix wants to merge 3 commits into
christofferok:masterfrom
unamix:patch-1

Conversation

@unamix

@unamix unamix commented Dec 3, 2017

Copy link
Copy Markdown

Escape dollar signs in pattern
Add /resources/assets/js to scan dirs
@christofferok

Copy link
Copy Markdown
Owner

Thanks for the pull request. I'm not that familiar with vue-i18n, but this change would only find the occurrences of $t, but the saved lang files would still be in the Laravel json format. Looking at the vue-i18n documentation it looks like it is expecting this type of format:

const messages = {
  en: {
    message: {
      hello: 'hello world'
    }
  },
  ja: {
    message: {
      hello: 'こんにちは、世界'
    }
  }
}

I think this is a little outside the scope of this project. Maybe you could fork the project and make a vue-i18n version?

@unamix

unamix commented Dec 3, 2017

Copy link
Copy Markdown
Author

I use https://github.com/martinlindhe/laravel-vue-i18n-generator to generate these formatted files from the regular lang files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants