Skip to content

test: replace url in test_remote_html test case#453

Merged
chrismattmann merged 1 commit intochrismattmann:masterfrom
afuetterer:test
Mar 26, 2026
Merged

test: replace url in test_remote_html test case#453
chrismattmann merged 1 commit intochrismattmann:masterfrom
afuetterer:test

Conversation

@afuetterer
Copy link
Copy Markdown
Contributor

@afuetterer afuetterer commented Mar 9, 2026

I don't know why http://neverssl.com/index.html was used in the test case, but it failed a lot to access that site due to

FAILED tests/test_tika.py::CreateTest::test_remote_html - RuntimeError: Failed to download http://neverssl.com/index.html: HTTPConnectionPool(host='neverssl.com', port=80): Max retries exceeded with url: /index.html (Caused by NewConnectionError("HTTPConnection(host='neverssl.com', port=80): Failed to establish a new connec...

If the reason was mainly to use that http / port 80, maybe switch to http://nossl.sh?

@chrismattmann
Copy link
Copy Markdown
Owner

@afuetterer I can't merge this due to conflicts. Can you merge/rebase and then update this PR?

@afuetterer afuetterer marked this pull request as draft March 26, 2026 05:28
@afuetterer afuetterer marked this pull request as ready for review March 26, 2026 07:41
@afuetterer
Copy link
Copy Markdown
Contributor Author

Conflicts are resolved.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 57.143% (+0.2%) from 56.975%
when pulling a221060 on afuetterer:test
into ea557f9 on chrismattmann:master.

@chrismattmann chrismattmann merged commit d671684 into chrismattmann:master Mar 26, 2026
2 checks passed
@chrismattmann
Copy link
Copy Markdown
Owner

Excellent, merged!

@afuetterer afuetterer deleted the test branch March 27, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants