chore: remove unused Timestamp.kt and fix ValentineCardStoreTest - #30
chore: remove unused Timestamp.kt and fix ValentineCardStoreTest#30chrishonson wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ec21732ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import kotlinx.coroutines.ExperimentalCoroutinesApi | ||
| import kotlinx.coroutines.test.runTest | ||
| import org.junit.Assert.assertTrue | ||
| import org.junit.Test |
There was a problem hiding this comment.
The test now imports JUnit (org.junit.*) in commonTest, which is compiled for all KMP targets. The build only adds libs.kotlin.test to commonTest (see composeApp/build.gradle.kts), so JUnit isn’t available for native/JS targets; this will break compilation when running commonTest for iOS or other non-JVM targets. Use kotlin.test.Test/kotlin.test.assertTrue (or move the test to an androidTest/jvmTest source set) to keep the common tests portable.
Useful? React with 👍 / 👎.
2 participants
No description provided.