nightshift/20260120 135805 - #26
Conversation
chrishonson
commented
Jan 20, 2026
chrishonson
commented
- feat: add startup screen with dark theme heart animation
- Fix: Remove the virtual card completely. Nothing should be named virtualcard
- Fix: Add a startup screen with a dark theme valentines day heart animation
- Implement StartupContract, StartupStore, and StartupScreen - Integrate StartupScreen into App.kt with a 3-second delay - Follow MVI architecture and pure UI patterns
- Added recipientName to ValentineCardState - Added UpdateRecipientName and NextMessage intents - Updated ValentineCardStore with multiple messages and cycling logic - Refactored ValentineCardScreen into Container and Pure Content components - Added unit tests for new functionality
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d46a4c2f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assertEquals("My Love", state.recipientName) | ||
| assertEquals("Happy Valentine's Day!", state.message) | ||
| assertFalse(state.isOpened) |
There was a problem hiding this comment.
These assertions reference recipientName and isOpened, but the new ValentineCardState only has message and isRevealed, and the intent set no longer includes OpenCard/UpdateRecipient. As written, the common tests will not compile (missing properties/intents) whenever the test task runs, causing CI to fail. Update the tests (or the state/intent API) to match the new Valentine card contract.
Useful? React with 👍 / 👎.
2 participants
